lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling
Ok, thanks, that's better. I'll put your modifications in the patch v3.

----- Mail original -----
De: "Ingo Molnar" <mingo@kernel.org>
À: "Tony Luck" <tony.luck@intel.com>
Cc: "Mathieu Souchaud" <mattieu.souchaud@free.fr>, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Envoyé: Mardi 6 Mai 2014 08:27:10
Objet: Re: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling


* Luck, Tony <tony.luck@intel.com> wrote:

> +err_device_create:
> + /*
> + * mce_device_remove behave properly if mce_device_create was not
> + * called on that device.
> + */
> + for_each_possible_cpu(i)
> + mce_device_remove(i);
>
> grammar comment "s/behave/behaves/"
>
> Though perhaps this is better:
>
> /*
> * We didn't keep track of which devices were created above, but
> * even if we had, the set of online cpus might have changed.
> * Play safe and remove for every possible cpu since mce_device_remove()
> * will do the right thing.
> */

and I guess:

s/cpu since/cpu, since/

?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-05-07 12:01    [W:0.208 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site