lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] crypto: qce: Add dma and sg helpers
On 04/03/2014 09:25 PM, Josh Cartwright wrote:
> Nitworthy comments :).
>
> On Thu, Apr 03, 2014 at 07:18:00PM +0300, Stanimir Varbanov wrote:
> [..]
>> +++ b/drivers/crypto/qce/dma.c
> [..]
>> +int qce_dma_request(struct device *dev, struct qce_dma_data *dma)
>> +{
>> + unsigned int memsize;
>> + void *va;
>> + int ret;
>> +
>> + dma->txchan = dma_request_slave_channel_reason(dev, "tx");
>> + if (IS_ERR(dma->txchan)) {
>> + ret = PTR_ERR(dma->txchan);
>> + return ret;
>> + }
>> +
>> + dma->rxchan = dma_request_slave_channel_reason(dev, "rx");
>> + if (IS_ERR(dma->rxchan)) {
>> + ret = PTR_ERR(dma->rxchan);
>> + goto error_rx;
>> + }
>> +
>> + memsize = QCE_RESULT_BUF_SZ + QCE_IGNORE_BUF_SZ;
>> + va = kzalloc(memsize, GFP_KERNEL);
>> + if (!va) {
>> + ret = -ENOMEM;
>> + goto error_nomem;
>> + }
>> +
>> + dma->result_buf = va;
>> + dma->ignore_buf = dma->result_buf + QCE_RESULT_BUF_SZ;
>> +
>> + return 0;
>> +error_nomem:
>> + if (!IS_ERR(dma->rxchan))
>
> How could this condition ever be false?

Good catch. This is a leftover after error path restructuring. Will fix
it on next version.

--
regards,
Stan


\
 
 \ /
  Last update: 2014-04-04 11:01    [W:0.234 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site