Messages in this thread | | | Date | Fri, 11 Apr 2014 13:12:27 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms |
| |
On 04/10, Stanimir Varbanov wrote: > On 04/09/2014 03:09 AM, Stephen Boyd wrote: > > On 04/03, Stanimir Varbanov wrote: > > > >> + > >> + return 0; > >> +} > >> + > >> +static int qce_ahash_import(struct ahash_request *req, const void *in) > >> +{ > >> + struct qce_sha_reqctx *rctx = ahash_request_ctx(req); > >> + u32 flags = rctx->flags; > >> + bool hmac = IS_SHA_HMAC(flags); > >> + int ret; > >> + > >> + if (IS_SHA1(flags) || IS_SHA1_HMAC(flags)) { > >> + struct sha1_state *state = (struct sha1_state *)in; > > > > Unnecessary cast from void *. > > Nope, "in" is "const void *". Cast is needed to avoid compiler warnings. >
Ouch. Why are we casting away const? It should be possible to make qce_import_common() take const state and buffer arguments?
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |