Messages in this thread | | | Date | Wed, 30 Apr 2014 17:25:55 +0100 | From | David Vrabel <> | Subject | Re: [PATCH v1] Documentation and two bug-fixes for Xen pciback. |
| |
On 30/04/14 14:54, Konrad Rzeszutek Wilk wrote: > Hey, > > This patchset is just a simple documentation and two bug-fixes > to the Xen pciback. I am still looking at implementing the proper > way of doing reset for the devices - based on David's feedback - but > that is going to take a big of time. In the meantime this patchset > is presented as today is the documentation day! > > > drivers/xen/xen-pciback/pci_stub.c | 25 +++++++++++++++++++------ > drivers/xen/xen-pciback/xenbus.c | 4 ++++ > 2 files changed, 23 insertions(+), 6 deletions(-) > > Konrad Rzeszutek Wilk (6): > xen-pciback: Cleanup up pcistub_put_pci_dev > xen-pciback: First reset, then free. > xen-pciback: Document when we FLR an PCI device. > xen/pciback: Document when the 'unbind' and 'bind' functions are called. > xen/pciback: Document the entry points for 'pcistub_put_pci_dev'
These:
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> xen/pciback: Don't call xen_pcibk_config_init_dev when device de-assigned.
Could you just check that nothing relied on the dyn_fields() being deleted here.
David
| |