Messages in this thread | | | Date | Wed, 30 Apr 2014 15:40:39 +0100 | From | "Jan Beulich" <> | Subject | Re: [PATCH v1 6/6] xen/pciback: Don't call xen_pcibk_config_init_dev when device de-assigned. |
| |
>>> On 30.04.14 at 15:54, <konrad.wilk@oracle.com> wrote: > When the device is de-assigned from a guest (but still owned > by xen-pciback) we would needlessly free all of its dynamic > entries.
I wonder whether that isn't intentional - dynamic fields are only being used for what comes through the "quirks" attribute.
> --- a/drivers/xen/xen-pciback/pci_stub.c > +++ b/drivers/xen/xen-pciback/pci_stub.c > @@ -288,8 +288,6 @@ void pcistub_put_pci_dev(struct pci_dev *dev) > > /* And cleanup up our emulated fields. */ > xen_pcibk_config_reset_dev(dev); > - xen_pcibk_config_free_dyn_fields(dev); > -
Irrespective of the above, patch title and contents are out of sync.
Jan
| |