Messages in this thread Patch in this message | | | From | Konrad Rzeszutek Wilk <> | Subject | [PATCH v1 2/6] xen-pciback: First reset, then free. | Date | Wed, 30 Apr 2014 09:54:07 -0400 |
| |
We were doing the operations of freeing and reset in the wrong order. Granted nothing broke because the reset functions just set bar->which = 0.
But nonethless this was incorrect.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> --- drivers/xen/xen-pciback/pci_stub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 5300a21..36dd4f3 100644 --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -278,8 +278,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev) xen_pcibk_reset_device(dev); /* And cleanup up our emulated fields. */ - xen_pcibk_config_free_dyn_fields(dev); xen_pcibk_config_reset_dev(dev); + xen_pcibk_config_free_dyn_fields(dev); xen_unregister_device_domain_owner(dev); -- 1.8.5.3
| |