Messages in this thread | | | Date | Tue, 25 Mar 2014 21:37:24 +0100 | Subject | Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() | From | Linus Walleij <> |
| |
On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> This looks kinda wrong I didn't manage to fully test it. > The driver calls irq_alloc_domain_generic_chips() which creates a gc and > adds it to gc_list. The driver later then calls irq_setup_generic_chip() > which also initializes the gc and adds it to the gc_list() and this > corrupts the list. > I can't find a single chip in tree which uses both functions so I think > that irq_setup_generic_chip() can be dropped. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Jamie: comments?
Can you instead of this try to use my new generic gpiolib irqchip helpers that I just merged to the GPIO tree?
Yours, Linus Walleij
| |