Messages in this thread | | | Date | Tue, 25 Mar 2014 21:43:49 +0100 | Subject | Re: [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront. | From | Linus Walleij <> |
| |
On Sat, Mar 22, 2014 at 1:37 PM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> Linus, I don't understand why you need the mapping upfront.
This is because irqchips and gpiochips need to be orthogonal APIs.
> I looked at > those two links and you quote gpio_to_irq() which is not required.
In a *lot* of drivers it is implicitly required that gpio_to_irq() is called first because they only call irq_create_mapping() there. (And not in subsequent interrupt handlers etc.)
No matter what, I would worry less about that and spend some time on using my new gpiolib helpers for gpiochip_irqchip_add() and gpiochip_set_chained_irqchip().
Yours, Linus Walleij
| |