[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()
This looks kinda wrong I didn't manage to fully test it.
The driver calls irq_alloc_domain_generic_chips() which creates a gc and
adds it to gc_list. The driver later then calls irq_setup_generic_chip()
which also initializes the gc and adds it to the gc_list() and this
corrupts the list.
I can't find a single chip in tree which uses both functions so I think
that irq_setup_generic_chip() can be dropped.

Signed-off-by: Sebastian Andrzej Siewior <>
drivers/gpio/gpio-dwapb.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index ed5711f..4d25a06b 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
ct->regs.ack = GPIO_PORTA_EOI;
ct->regs.mask = GPIO_INTMASK;

- irq_setup_generic_chip(irq_gc, IRQ_MSK(port->bgc.gc.ngpio),
irq_set_chained_handler(irq, dwapb_irq_handler);
irq_set_handler_data(irq, gpio);


 \ /
  Last update: 2014-03-20 21:21    [W:0.118 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site