Messages in this thread | | | Date | Thu, 27 Feb 2014 10:55:18 +0530 | Subject | Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c | From | Viresh Kumar <> |
| |
Hi Rashika,
On 26 February 2014 22:08, Rashika Kheria <rashika.kheria@gmail.com> wrote: > Mark function as static in cpufreq.c because it is not > used outside this file. > > This eliminates the following warning in cpufreq.c: > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for 'show_boost' [-Wmissing-prototypes]
Can you please elaborate how this warning is related to the non-static definition of this function?
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > --- > drivers/cpufreq/cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 08ca8c9..54fd670 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition); > /********************************************************************* > * SYSFS INTERFACE * > *********************************************************************/ > -ssize_t show_boost(struct kobject *kobj, > +static ssize_t show_boost(struct kobject *kobj, > struct attribute *attr, char *buf) > { > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled); > -- > 1.7.9.5 >
| |