Messages in this thread | | | Date | Wed, 26 Feb 2014 08:52:49 -0800 | From | Dirk Brandewie <> | Subject | Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c |
| |
On 02/26/2014 08:41 AM, Josh Triplett wrote: > On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote: >> Mark function as static in cpufreq.c because it is not >> used outside this file. >> >> This eliminates the following warning in cpufreq.c: >> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes] >> >> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > > I don't see any uses of this function in cpufreq.c; have uses appeared > in a development branch? >
This is a sysfs accessor used to control the boost feature it is not used by the core but userspace.
>> drivers/cpufreq/cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c >> index 08ca8c9..54fd670 100644 >> --- a/drivers/cpufreq/cpufreq.c >> +++ b/drivers/cpufreq/cpufreq.c >> @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition); >> /********************************************************************* >> * SYSFS INTERFACE * >> *********************************************************************/ >> -ssize_t show_boost(struct kobject *kobj, >> +static ssize_t show_boost(struct kobject *kobj, >> struct attribute *attr, char *buf) >> { >> return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled); >> -- >> 1.7.9.5 >> > -- > To unsubscribe from this list: send the line "unsubscribe cpufreq" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |