Messages in this thread | | | Date | Mon, 3 Mar 2014 12:50:43 +0530 | Subject | Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c | From | Viresh Kumar <> |
| |
On 3 March 2014 09:12, Patrick Palka <patrick@parcs.ath.cx> wrote: > -Wmissing-prototypes warns when a non-static function is defined > before a corresponding prototype (usually inside an included header > file) is declared. In such a case, it is impossible to reference the > non-static function from another file, and therefore the function > should be marked static (usually). Hope that makes sense!
I understand that it should be made static as we don't have a prototype in any other header file, but I thought we shouldn't get the warning we are getting.
warning: no previous prototype for 'show_boost'
Because we have prototype/definition of function before it is used. Maybe a warning like:
local function should be marked static could have been there ;)
| |