Messages in this thread Patch in this message |  | | Date | Sun, 23 Feb 2014 23:33:19 +0000 (GMT) | From | Jingoo Han <> | Subject | Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse |
| |
On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: > > There is no reason to care about irq_desc in that context, escpecially > as irq_data for that interrupt is retrieved as well. > > Use the proper accessor for the msi descriptor > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Mohit Kumar <mohit.kumar@st.com> > Cc: pci <linux-pci@vger.kernel.org>
Acked-by: Jingoo Han <jg1.han@samsung.com>
A few days ago, I noticed that irq_data_get_msi() can be used. However, I did not submit the same patch. I really appreciate your patch. :-)
Best regards, Jingoo Han
> --- > drivers/pci/host/pcie-designware.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > Index: tip/drivers/pci/host/pcie-designware.c > =================================================================== > --- tip.orig/drivers/pci/host/pcie-designware.c > +++ tip/drivers/pci/host/pcie-designware.c > @@ -294,14 +294,12 @@ no_valid_irq: > static void clear_irq(unsigned int irq) > { > unsigned int pos, nvec; > - struct irq_desc *desc; > struct msi_desc *msi; > struct pcie_port *pp; > struct irq_data *data = irq_get_irq_data(irq); > > /* get the port structure */ > - desc = irq_to_desc(irq); > - msi = irq_desc_get_msi_desc(desc); > + msi = irq_data_get_msi(data); > pp = sys_to_pcie(msi->dev->bus->sysdata); > if (!pp) { > BUG(); |  |