Messages in this thread |  | | Subject | Re: [PATCH 08/14] net: axienet: Removed checkpatch errors/warnings | From | Joe Perches <> | Date | Wed, 12 Feb 2014 16:31:34 -0800 |
| |
On Wed, 2014-02-12 at 16:55 +0100, Michal Simek wrote: > From: Srikanth Thokala <srikanth.thokala@xilinx.com>
trivia:
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> + netdev_err(lp->ndev, > + "axienet_device_reset DMA reset timeout!\n");
could you please align multi-line arguments to the appropriate open parenthesis?
netdev_err(lp->ndev, "axienet_device_reset DMA reset timeout!\n");
or maybe:
netdev_err(lp->ndev, "%s: "DMA reset timeout!\n", __func__);
> @@ -484,8 +484,8 @@ static void axienet_device_reset(struct net_device *ndev) > } > > if (axienet_dma_bd_init(ndev)) { > - dev_err(&ndev->dev, "axienet_device_reset descriptor " > - "allocation failed\n"); > + netdev_err(ndev, > + "axienet_device_reset descriptor allocation failed\n");
etc, et al.
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c [] > @@ -161,19 +161,19 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np) > > np1 = of_find_node_by_name(NULL, "cpu"); > if (!np1) { > - printk(KERN_WARNING "%s(): Could not find CPU device node.", > - __func__); > - printk(KERN_WARNING "Setting MDIO clock divisor to " > - "default %d\n", DEFAULT_CLOCK_DIVISOR); > + netdev_warn(lp->ndev, "Could not find CPU device node.");
missing trailing "\n" to terminate message.
> + netdev_warn(lp->ndev, > + "Could not find clock ethernet controller property.");
here too. (and alignment)
|  |