| Subject | Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries | From | "Martin K. Petersen" <> | Date | Wed, 03 Dec 2014 22:05:49 -0500 |
| |
>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes:
Sreekanth> 1. Removed the upper boundary restriction for the module Sreekanth> parameter max_sgl_entries. Earlier, the max_sgl_entries was Sreekanth> capped at the SCSI_MAX_SG_SEGMENTS kernel definition. With Sreekanth> this change, the user would be able to set the Sreekanth> max_sgl_entries to any value.
Shouldn't you be capping at SCSI_MAX_SG_CHAIN_SEGMENTS (or the actual hw limit)?
-- Martin K. Petersen Oracle Linux Engineering
|