Messages in this thread | | | Date | Fri, 07 Nov 2014 16:48:59 -0500 (EST) | Subject | Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter | From | David Miller <> |
| |
From: Al Viro <viro@ZenIV.linux.org.uk> Date: Thu, 6 Nov 2014 03:25:34 +0000
> OK, I've taken the beginning of the old queue on top of net-next; it's > in git://git.kernel.org//pub/scm/linux/kernel/git/viro/vfs.git iov_iter-net.
What I see in there looks good. I wonder if we can somehow make msghdr pointer args const... but this is not so important now.
Some minor coding style nits, comments:
/* Like * this. */
and for multi-line function calls in the networking, align the second and subsequent lines at the first column after the openning parenthesis of the first line.
Thanks.
| |