Messages in this thread | | | Date | Fri, 7 Nov 2014 22:31:53 +0000 | From | Al Viro <> | Subject | Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter |
| |
On Fri, Nov 07, 2014 at 10:11:14PM +0000, Al Viro wrote:
> I'm looking through the tree right now; so far it looks like we can just > move those suckers to the point where we validate iovec and lose them > from low-level iovec and csum copying completely. I still haven't finished > tracing all possible paths for address to arrive at the points where we > currently check that stuff, but so far it looks very doable.
BTW, csum side of that is also chock-full of duplicate access_ok() - e.g. generic csum_and_copy_from_user() checks before calling csum_partial_copy_from_user(). And generic instance of that is using __copy_from_user(), all right, but a _lot_ of non-default instances repeat that access_ok().
| |