Messages in this thread | | | Date | Thu, 6 Nov 2014 14:46:29 +0800 | From | Herbert Xu <> | Subject | Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt |
| |
On Thu, Nov 06, 2014 at 06:43:18AM +0000, Al Viro wrote: > On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > > + /* We only need the first two bytes. */ > > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2); > > + if (err) > > + return err; > > + > > + fl4->fl4_icmp_type = icmph.type; > > + fl4->fl4_icmp_code = icmph.code; > > That's more readable, but that exposes another problem in there - we read > the same piece of userland data twice, with no promise whatsoever that we'll > get the same value both times...
Sure, but you have to be root anyway to write to raw sockets.
Patches are welcome :)
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |