Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 5/6] Documentation: i2c: Add APM X-Gene platform SLIMpro I2C driver documentation | Date | Tue, 11 Nov 2014 22:40:01 +0100 |
| |
On Tuesday 07 October 2014 17:06:48 Feng Kan wrote: > Add APM X-Gene platform SLIMpro I2C driver documentation. >
Don't just repeat the subject line, explain what this is for.
> Signed-off-by: Feng Kan <fkan@apm.com> > Signed-off-by: Hieu Le <hnle@apm.com> > --- > .../devicetree/bindings/i2c/i2c-xgene-slimpro.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-xgene-slimpro.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-xgene-slimpro.txt b/Documentation/devicetree/bindings/i2c/i2c-xgene-slimpro.txt > new file mode 100644 > index 0000000..1a79d53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-xgene-slimpro.txt > @@ -0,0 +1,20 @@ > +APM X-Gene SLIMpro Mailbox I2C Driver > + > +This is a I2C driver that access the I2C bus through the mailbox mechanism. > +There is documentation of the mailbox driver in the > +Documentation/devicetree/binding/mailbox/xgene-slimpro-mbox.txt > + > +Required properties : > + > + - compatible : should be "apm,xgene-slimpro-i2c" > + - mbox : ptr to the mailbox dts node, use the name of the mailbox as the > + first parameter. The second parameter is the channel number. > + The APM X-Gene SLIMpro mailbox has 8 channels. > + - mbox-names : the name of the mailbox channel.
The current form of the mailbox interface no longer uses mbox-names, so just drop that. In the old form, the binding would have been incomplete because you don't list the required name.
Arnd
| |