lkml.org 
[lkml]   [2014]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: pinctrl-msm build error on Linus' tree
From
On Thu, Oct 9, 2014 at 1:12 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Wed, Oct 08, 2014 at 06:42:55PM -0400, Josh Boyer wrote:

>> However, there is literally nothing else in the tree that calls or
>> provides those functions:
>>
>> [jwboyer@vader linux]$ git grep unregister_restart_handler
>> drivers/pinctrl/qcom/pinctrl-msm.c: unregister_restart_handler(&pctrl->resta
>> [jwboyer@vader linux]$
>>
>>
>> I'm rather confused. How was this commit built and tested?

I guess the dependent tree was being pulled into linux-next before
the pinctrl tree, and so the end result was working?

> Looks like the pinctrl tree did not include the merge with the immutable
> branch with the necessary infrastructure in its pull request to Linus :-(.

Yeah maybe I missed some pull request for that, such things happen.

> As for how it was tested in the pinctrl tree, no idea. Maybe pinctrl-msm has
> some dependency which was missing in the pinctrl tree and came in through
> a different pull request.

See above.

Anyway, it is a minor platform, not x86_64. So don't exaggerate
this thing, and besides the restart notifiers are great.

If we go down the route of trying to always avoid all trouble in the
world by adding more procedure I guess we shouldn't shoehorn
too much into the same merge window and should have this
postponed to v3.19. But I don't know if it buys us so much.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-10-09 10:02    [W:0.104 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site