| Date | Thu, 23 Oct 2014 15:54:12 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 10/14] net: dsa/mv88e6352: Implement EEPROM access functions |
| |
On Wed, Oct 22, 2014 at 09:03:18PM -0700, Guenter Roeck wrote: > MV88E6352 supports read and write access to its configuration eeprom.
Hi Guenter
I don't have the datasheet for the MV88E6352. Is the EEPROM built in, or external on an i2c bus?
> +static int mv88e6352_get_eeprom_len(struct dsa_switch *ds) > +{ > + return 0x200; > +}
How do you handle the case of it being external and not populated. Would it not be better to try to detect it here, and return 0 if it does not exist?
Andrew
|