Messages in this thread |  | | Date | Thu, 23 Oct 2014 09:40:52 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 10/14] net: dsa/mv88e6352: Implement EEPROM access functions |
| |
On Thu, Oct 23, 2014 at 03:54:12PM +0200, Andrew Lunn wrote: > On Wed, Oct 22, 2014 at 09:03:18PM -0700, Guenter Roeck wrote: > > MV88E6352 supports read and write access to its configuration eeprom. > > Hi Guenter > > I don't have the datasheet for the MV88E6352. Is the EEPROM built in, > or external on an i2c bus? > External.
> > +static int mv88e6352_get_eeprom_len(struct dsa_switch *ds) > > +{ > > + return 0x200; > > +} > > How do you handle the case of it being external and not populated. > Would it not be better to try to detect it here, and return 0 if it > does not exist? > Makes sense, if it is detectable that it the EEPROM not there. Browsing through the datasheet, I don't see how I could detect it; there does not seem to be a status bit indicating if the EEPROM is there or not. There are sw_mode pins which determine if the eeprom should be loaded after reset or not, but I don't see anything in the register set which would tell me.
Chris, do you know if there is a means to detect if the EEPROM is present on the MV88E6352 ?
Thanks, Guenter
|  |