Messages in this thread |  | | Date | Thu, 23 Oct 2014 10:24:44 +0200 | From | Richard Cochran <> | Subject | Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring |
| |
On Wed, Oct 22, 2014 at 10:06:41PM -0700, Guenter Roeck wrote: > On 10/22/2014 09:37 PM, Florian Fainelli wrote: > >You probably want the number of temperature sensors to come from the > >switch driver, and support arbitrary number of temperature sensors? > > In that case we would need the number of sensors, pass a sensor index, > and create a dynamic number of attributes. The code would get much more > complex without real benefit unless there is such a chip - and if there is, > we can still change the code at that time. I would prefer to keep it simple > for now.
Better to do it correctly, right from the start. There *will* be such a chip one day, and the person wanting to add it will appreciate the solid foundation (even if that person ends up being you ;).
Thanks, Richard
|  |