Messages in this thread | | | Date | Thu, 23 Oct 2014 22:40:59 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring |
| |
On 10/23/2014 10:03 PM, David Miller wrote: > From: Guenter Roeck <linux@roeck-us.net> > Date: Wed, 22 Oct 2014 22:06:41 -0700 > >> On 10/22/2014 09:37 PM, Florian Fainelli wrote: >>> 2014-10-22 21:03 GMT-07:00 Guenter Roeck <linux@roeck-us.net>: >>>> Some Marvell switches provide chip temperature data. >>>> Add support for reporting it to the dsa infrastructure. >>>> >>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >>>> --- >>> [snip] >>> >>>> +/* hwmon support >>>> ************************************************************/ >>>> + >>>> +#if defined(CONFIG_HWMON) || (defined(MODULE) && >>>> defined(CONFIG_HWMON_MODULE)) >>> >>> IS_ENABLED(CONFIG_HWMON)? >>> >> >> Hi Florian, >> >> unfortunately, that won't work; I had it initially and got a nice >> error message >> from Fengguang's build test bot. > > Then the Kconfig dependencies are broken. > > Fix Kconfig to only allow legal combinations. >
I see two options for that:
- Add select HWMON to the NET_DSA Kconfig entry. Example is Broadcom TIGON3 driver.
- Add a DSA_HWMON Kconfig entry to define the dependencies and to let the user select if the functionality should be enabled. Example is Intel IGB driver.
Any preference from your side ? If no, I'll go with the latter.
Thanks, Guenter
| |