lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] sched: idle: Get the next timer event and pass it the cpuidle framework
On Mon, 20 Oct 2014, Daniel Lezcano wrote:

> Following the logic of the previous patch, retrieve from the idle task the
> expected timer sleep duration and pass it to the cpuidle framework.
>
> Take the opportunity to remove the unused headers in the menu.c file.
>
> This patch does not change the current behavior.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

One minor nit below.

> @@ -211,6 +212,12 @@ static void cpu_idle_loop(void)
> latency_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY);
>
> /*
> + * The next timer event in us
> + */

This 3-line comment is redundant. The code is obvious enough on its own.

> + next_timer_event = ktime_to_us(
> + tick_nohz_get_sleep_length());

I'd suggest this form for better readability:

next_timer_event =
ktime_to_us(tick_nohz_get_sleep_length());

Other than that...

Acked-by: Nicolas Pitre <nico@linaro.org>

> +
> + /*
> * In poll mode we reenable interrupts and spin.
> *
> * If the latency req is zero, we don't want to
> @@ -227,7 +234,8 @@ static void cpu_idle_loop(void)
> tick_check_broadcast_expired())
> cpu_idle_poll();
> else
> - cpuidle_idle_call(latency_req);
> + cpuidle_idle_call(latency_req,
> + next_timer_event);
>
> arch_cpu_idle_exit();
> }
> --
> 1.9.1
>
>


\
 
 \ /
  Last update: 2014-10-22 23:01    [W:0.123 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site