Messages in this thread | | | Date | Fri, 24 Oct 2014 15:38:10 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed |
| |
On Mon, Oct 20, 2014 at 06:25:41PM +0200, Daniel Lezcano wrote: > +++ b/kernel/sched/idle.c > @@ -162,7 +162,8 @@ use_default: > /* > * Give the governor an opportunity to reflect on the outcome > */ > - cpuidle_reflect(dev, entered_state); > + if (entered_state >= 0) > + cpuidle_reflect(dev, entered_state); >
Given we'll do use_default: when next_state < 0, we actually never get here unless this is true.
| |