lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] sched: idle: Get the next timer event and pass it the cpuidle framework
From
Hi Daniel,

On Mon, Oct 20, 2014 at 9:55 PM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> Following the logic of the previous patch, retrieve from the idle task the
> expected timer sleep duration and pass it to the cpuidle framework.
>
> Take the opportunity to remove the unused headers in the menu.c file.
>
> This patch does not change the current behavior.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/cpuidle/cpuidle.c | 11 +++++------
> drivers/cpuidle/governors/ladder.c | 3 ++-
> drivers/cpuidle/governors/menu.c | 8 ++------
> include/linux/cpuidle.h | 8 +++++---
> kernel/sched/idle.c | 16 ++++++++++++----
> 5 files changed, 26 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 372c36f..64f5800 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -8,16 +8,12 @@
> * This code is licenced under the GPL.
> */
>
> -#include <linux/clockchips.h>
> #include <linux/kernel.h>
> #include <linux/mutex.h>
> -#include <linux/sched.h>
> #include <linux/notifier.h>
> #include <linux/pm_qos.h>
> #include <linux/cpu.h>
> #include <linux/cpuidle.h>
> -#include <linux/ktime.h>
> -#include <linux/hrtimer.h>
> #include <linux/module.h>
> #include <trace/events/power.h>
>
> @@ -155,11 +151,13 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
> *
> * @drv: the cpuidle driver
> * @dev: the cpuidle device
> + * @latency_req: the latency constraint when choosing an idle state

You might want to include this change in the previous patch itself.

> + * @next_timer_event: the duration until the timer expires
> *
> * Returns the index of the idle state.
> */

Regards
Preeti U Murthy


\
 
 \ /
  Last update: 2014-10-28 08:21    [W:0.139 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site