lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 07/20] perf: Add api for pmus to write to AUX area
Date
Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, Oct 13, 2014 at 04:45:35PM +0300, Alexander Shishkin wrote:
>> + /*
>> + * Nesting is not supported for AUX area, make sure nested
>> + * writers are caught early
>> + */
>> + if (WARN_ON_ONCE(local_xchg(&rb->aux_nest, 1)))
>> + goto err_put;
>
> Note that printk() from NMI is prone to making your machine die, not
> that I have a better option though.

Indeed, but if your driver is really attempting nested
perf_aux_output_begin()s, then you had it coming to you anyway.

Regards,
--
Alex


\
 
 \ /
  Last update: 2014-10-22 16:41    [W:1.452 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site