lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 06/20] perf: Add AUX record
On Wed, Oct 22, 2014 at 05:18:29PM +0300, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
>
> > On Mon, Oct 13, 2014 at 04:45:34PM +0300, Alexander Shishkin wrote:
> >> + /*
> >> + * Records that new data landed in the AUX buffer part.
> >> + *
> >> + * struct {
> >> + * struct perf_event_header header;
> >> + *
> >> + * u64 aux_offset;
> >> + * u64 aux_size;
> >> + * u64 flags;
> >> + * struct sample_id sample_id;
> >> + * };
> >> + */
> >> + PERF_RECORD_AUX = 11,
> >
> > Given the discussion with the ARM people the last time, do we want to
> > add the possibility of a variable data field in this event? Its easy to
> > add now, harder to do later (although not impossible).
>
> Iirc, what they want is to save a once-per-session chunk of data, which
> would be better synthesized by perf record than sent from a pmu driver?
>
> We do something like that with PT right now, perf record looks at pmu's
> sysfs attributes and stores them in some synthesized record.

Right, I just got to that. So I wasn't entirely sure if perf_event_open
time conditions where sufficient for them, if they are then yes that
could work.


\
 
 \ /
  Last update: 2014-10-22 17:41    [W:1.236 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site