lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver
    On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote:
    > +static void pt_event_start(struct perf_event *event, int mode)
    > +{
    > + struct pt *pt = this_cpu_ptr(&pt_ctx);
    > + struct pt_buffer *buf = perf_get_aux(&pt->handle);
    > +
    > + if (pt_is_running() || !buf || pt_buffer_is_full(buf, pt) ||
    > + pt_config(event)) {
    > + event->hw.state = PERF_HES_STOPPED;
    > + return;
    > + }
    > +
    > + ACCESS_ONCE(pt->handle_nmi) = 1;
    > + event->hw.state = 0;
    > +
    > + pt_config_buffer(buf->cur->table, buf->cur_idx,
    > + buf->output_off);
    > + wrmsrl(MSR_IA32_RTIT_STATUS, 0);
    > + pt_config_start(true);
    > +}

    That's two RTIT_CTL writes, should we not try and merge those?


    \
     
     \ /
      Last update: 2014-10-22 18:01    [W:4.196 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site