Messages in this thread Patch in this message | | | Subject | [PATCH v1 04/10] MIPS: Remove "weak" from platform_maar_init() declaration | From | Bjorn Helgaas <> | Date | Wed, 15 Oct 2014 11:06:09 -0600 |
| |
arch/mips/mm/init.c provides a default platform_maar_init() definition explicitly marked "weak". arch/mips/mti-malta/malta-memory.c provides its own definition intended to override the default, but the "weak" attribute on the declaration applied to this as well, so the linker chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node decl")).
Remove the "weak" attribute from the declaration so we always prefer a non-weak definition over the weak one, independent of link order.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: linux-mips@linux-mips.org --- arch/mips/include/asm/maar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/maar.h b/arch/mips/include/asm/maar.h index 6c62b0f899c0..b02891f9caaf 100644 --- a/arch/mips/include/asm/maar.h +++ b/arch/mips/include/asm/maar.h @@ -26,7 +26,7 @@ * * Return: The number of MAAR pairs configured. */ -unsigned __weak platform_maar_init(unsigned num_pairs); +unsigned platform_maar_init(unsigned num_pairs); /** * write_maar_pair() - write to a pair of MAARs
| |