lkml.org 
[lkml]   [2014]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration
    From
    On Wed, Oct 15, 2014 at 10:06 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
    >
    > kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition
    > explicitly marked "weak". Several architectures provide their own
    > definitions intended to override the default, but the "weak" attribute on
    > the declaration applied to the arch definitions as well, so the linker
    > chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak
    > annotation from pcibios_get_phb_of_node decl")).
    >
    > Remove the "weak" attribute from the declaration so we always prefer a
    > non-weak definition over the weak one, independent of link order.
    >
    > Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add declaration to header")
    > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    > CC: Harvey Harrison <harvey.harrison@gmail.com>

    Reviewed-by: Harvey Harrison <harvey.harrison@gmail.com>

    This was likely simply an error in my patch, likely just copied the
    function definition and didn't even notice the
    weak annotation at the time.

    Harvey


    \
     
     \ /
      Last update: 2014-10-16 02:21    [W:3.660 / U:1.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site