Messages in this thread | | | Date | Thu, 16 Oct 2014 17:42:11 -0700 | From | sathyanarayanan kuppuswamy <> | Subject | Re: [PATCH v1 02/10] x86, intel-mid: Remove "weak" from function declarations |
| |
Hi Bjorn,
On 10/15/2014 04:26 PM, Bjorn Helgaas wrote: > [+cc David, Kuppuswamy, x86; sorry, I botched my "stg mail" so you > weren't included the first time] > > On Wed, Oct 15, 2014 at 11:05 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> For the following interfaces: >> >> get_penwell_ops() >> get_cloverview_ops() >> get_tangier_ops() >> >> there is only one implementation, so they do not need to be marked "weak". >> >> Remove the "weak" attribute from their declarations. >> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >> CC: David Cohen <david.a.cohen@linux.intel.com> >> CC: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> CC: x86@kernel.org >> --- >> arch/x86/platform/intel-mid/intel_mid_weak_decls.h | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h >> index 46aa25c8ce06..3c1c3866d82b 100644 >> --- a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h Please remove this file and move the contents to asm/intel-mid.h. >> +++ b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h >> @@ -10,10 +10,9 @@ >> */ >> >> >> -/* __attribute__((weak)) makes these declarations overridable */ >> /* For every CPU addition a new get_<cpuname>_ops interface needs >> * to be added. >> */ >> -extern void *get_penwell_ops(void) __attribute__((weak)); >> -extern void *get_cloverview_ops(void) __attribute__((weak)); >> -extern void *get_tangier_ops(void) __attribute__((weak)); >> +extern void *get_penwell_ops(void); >> +extern void *get_cloverview_ops(void); >> +extern void *get_tangier_ops(void); >>
-- Sathyanarayanan Kuppuswamy Android kernel developer
| |