Messages in this thread | | | Date | Thu, 9 Jan 2014 14:43:07 +0000 | Subject | Re: [PATCH 1/3] mfd: MAX6650/6651 support | From | Laszlo Papp <> |
| |
>> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest) >> +{ > > Probably best to use Regmap instead. > > regmap_i2c_read()
>> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value) >> +{ >> + struct max6651_dev *max6651 = i2c_get_clientdata(i2c); >> + int ret; > > Same here. > > regmap_i2c_write()
Hmm, but what Linus linked is using regmap_read/write(...) instead of regmap_i2c_read/write(...).
I thought I would need to be using the former. Perhaps, I misunderstand something?
I do not even find the aforementioend functions used by drivers based on this LXR result: http://lxr.free-electrons.com/ident?i=regmap_i2c_write
| |