Messages in this thread | | | Date | Fri, 10 Jan 2014 09:56:48 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 1/3] mfd: MAX6650/6651 support |
| |
On Thu, 09 Jan 2014, Laszlo Papp wrote:
> >> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest) > >> +{ > > > > Probably best to use Regmap instead. > > > > regmap_i2c_read() > > >> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value) > >> +{ > >> + struct max6651_dev *max6651 = i2c_get_clientdata(i2c); > >> + int ret; > > > > Same here. > > > > regmap_i2c_write() > > Hmm, but what Linus linked is using regmap_read/write(...) instead of > regmap_i2c_read/write(...). > > I thought I would need to be using the former. Perhaps, I > misunderstand something? > > I do not even find the aforementioend functions used by drivers based > on this LXR result: > http://lxr.free-electrons.com/ident?i=regmap_i2c_write
Linus is in a better position to know, use his suggestion.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |