lkml.org 
[lkml]   [2014]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs
From
As the cover page wrote, this was *not* meant to be a good code
because I wanted to get design feedback. I have asked that before,
too, and you claimed to send some code representing the idea. I have
just done that. I find it weird to get design feedback _after_ doing
all the coding.

Anyway, if you are not willing to give a design review without
finalizing the patch, then just scratch this. I will roll back to
using my previously rejected change in our repository.

On Tue, Jan 7, 2014 at 9:09 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Don't send private, off-list emails for poking or anything else
> related to upstreamming patches.
>
>> Important text here later. It is now just an attempt to get some feedback about
>> the design of the new features. This set has only been compilation tested, and
>> has many errors with checkpatch.pl, et al. Really, the point is only to get
>> feedback about the direction, as there has been a lot of paid work put into
>> this to work better with upstream after the previously rejected change simple
>> hwmon change.
>
> If you want to obtain time/advice from maintainers, most of which are
> already snowed-under, you have to earn it. Making submissions such as
> these are not conducive to your cause. Fix the Checkpatch errors and
> do your damnedest to ensure the code is the finest standard it can be.
>
> If you fail to adhere to these [1] three documents accidentally, then
> you will be guided. If you do so on purpose by sending intentionally
> sloppy code, then you are unlikely to gain any attention at all.
>
> [1]
> Documentation/CodingStyle
> Documentation/email-clients.txt
> Documentation/SubmittingPatches
>
>> Laszlo Papp (3):
>> mfd: MAX6650/6651 support
>> hwmon: (max6650) Convert to be a platform driver
>> gpio: MAX6650/6651 support
>>
>> drivers/gpio/Kconfig | 14 ++
>> drivers/gpio/Makefile | 2 +
>> drivers/gpio/gpio-max6651.c | 72 +++++++++
>> drivers/gpio/gpio-max665x.c | 301 ++++++++++++++++++++++++++++++++++++
>> drivers/hwmon/Kconfig | 2 +-
>> drivers/hwmon/max6650.c | 150 +++++++++---------
>> drivers/mfd/Kconfig | 11 ++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/max6651.c | 132 ++++++++++++++++
>> include/linux/mfd/max6651-private.h | 63 ++++++++
>> 10 files changed, 675 insertions(+), 73 deletions(-)
>> create mode 100644 drivers/gpio/gpio-max6651.c
>> create mode 100644 drivers/gpio/gpio-max665x.c
>> create mode 100644 drivers/mfd/max6651.c
>> create mode 100644 include/linux/mfd/max6651-private.h
>>
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-01-08 16:41    [W:0.725 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site