Messages in this thread Patch in this message | | | Subject | [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c | From | David Howells <> | Date | Fri, 03 Jan 2014 16:08:12 +0000 |
| |
Fix the following warning:
Documentation/misc-devices/mei/mei-amt-version.c: In function 'main': Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning: 'acmd.fd' is used uninitialized in this function [-Wuninitialized] if (cl->fd != -1) ^ Documentation/misc-devices/mei/mei-amt-version.c:443:21: note: 'acmd.fd' was declared here struct amt_host_if acmd; ^
The call chain:
-->main() -->amt_host_if_init() -->mei_init() -->mei_deinit()
results in this on the first time through because main()::acmd has not yet been initialised.
To fix this, acmd.fd needs to be initialised to -1.
Signed-off-by: David Howells <dhowells@redhat.com> cc: Tomas Winkler <tomas.winkler@intel.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> ---
Documentation/misc-devices/mei/mei-amt-version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/misc-devices/mei/mei-amt-version.c b/Documentation/misc-devices/mei/mei-amt-version.c index 49e4f770864a..7027a8da0ba0 100644 --- a/Documentation/misc-devices/mei/mei-amt-version.c +++ b/Documentation/misc-devices/mei/mei-amt-version.c @@ -440,7 +440,7 @@ out: int main(int argc, char **argv) { struct amt_code_versions ver; - struct amt_host_if acmd; + struct amt_host_if acmd = { .mei_cl.fd = -1 }; unsigned int i; uint32_t status; int ret;
| |