lkml.org 
[lkml]   [2014]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c
Date


> -----Original Message-----
> From: David Howells [mailto:dhowells@redhat.com]
> Sent: Friday, January 03, 2014 18:34
> To: Paul Bolle
> Cc: dhowells@redhat.com; akpm@linux-foundation.org; Greg Kroah-Hartman;
> Winkler, Tomas; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c
>
> Paul Bolle <pebolle@tiscali.nl> wrote:
>
> > But it turns out that call of mei_deinit() isn't needed at all. All of
> > the members of mei_cl will be set later in mei_init() and none will be
> > used before they are set. So we can simply drop this call of
> > mei_deinit()."
> >
> > Is that analysis (still) correct?
>
> It looks true as the code stands. Can you send me your patch?

Yes, the analysis is correct, need to fix the typo in the title and but otherwise ACK.

Thanks
Tomas





\
 
 \ /
  Last update: 2014-01-04 22:41    [W:0.043 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site