lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak
Date
From: Heinrich Schuchardt <xypron.glpk@gmx.de>

p is freed if NULL.
p is leaked if second calloc fails.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/staging/usbip/userspace/libsrc/names.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/usbip/userspace/libsrc/names.c b/drivers/staging/usbip/userspace/libsrc/names.c
index 3c8d28b..b2904e8 100644
--- a/drivers/staging/usbip/userspace/libsrc/names.c
+++ b/drivers/staging/usbip/userspace/libsrc/names.c
@@ -170,12 +170,12 @@ static void *my_malloc(size_t size)

p = calloc(1, sizeof(struct pool));
if (!p) {
- free(p);
return NULL;
}

p->mem = calloc(1, size);
if (!p->mem)
+ free(p);
return NULL;

p->next = pool_head;
--
1.7.10.4


\
 
 \ /
  Last update: 2014-01-28 00:21    [W:0.118 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site