Messages in this thread | | | Date | Tue, 28 Jan 2014 01:52:47 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak |
| |
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.glpk@gmx.de wrote: > From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Fix your email account so we can get this automatically from your email. Currently the From header on your email is just:
From: xypron.glpk@gmx.de
without your name.
> > p is freed if NULL. > p is leaked if second calloc fails. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/staging/usbip/userspace/libsrc/names.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/usbip/userspace/libsrc/names.c b/drivers/staging/usbip/userspace/libsrc/names.c > index 3c8d28b..b2904e8 100644 > --- a/drivers/staging/usbip/userspace/libsrc/names.c > +++ b/drivers/staging/usbip/userspace/libsrc/names.c > @@ -170,12 +170,12 @@ static void *my_malloc(size_t size) > > p = calloc(1, sizeof(struct pool)); > if (!p) { > - free(p); > return NULL; > }
Remove the curly braces from here since they are no longer needed.
> > p->mem = calloc(1, size); > if (!p->mem) > + free(p); > return NULL;
Add the curly braces here. They are required.
regards, dan carpenter
| |