Messages in this thread | | | Date | Wed, 25 Sep 2013 07:59:42 -0500 | From | Nishanth Menon <> | Subject | Re: [PATCH 19/20] regulator: twl: use devm_regulator_register() |
| |
On 17:15-20130925, Jingoo Han wrote: > Use devm_regulator_register() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/regulator/twl-regulator.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c > index 78aae4c..8ebd785 100644 > --- a/drivers/regulator/twl-regulator.c > +++ b/drivers/regulator/twl-regulator.c > @@ -1188,7 +1188,7 @@ static int twlreg_probe(struct platform_device *pdev) > config.driver_data = info; > config.of_node = pdev->dev.of_node; > > - rdev = regulator_register(&info->desc, &config); > + rdev = devm_regulator_register(&pdev->dev, &info->desc, &config); > if (IS_ERR(rdev)) { > dev_err(&pdev->dev, "can't register %s, %ld\n", > info->desc.name, PTR_ERR(rdev)); > @@ -1217,7 +1217,6 @@ static int twlreg_remove(struct platform_device *pdev) > struct regulator_dev *rdev = platform_get_drvdata(pdev); > struct twlreg_info *info = rdev->reg_data; > > - regulator_unregister(rdev); > kfree(info); > return 0; > } > -- > 1.7.10.4 > > Acked-by: Nishanth Menon <nm@ti.com> -- Regards, Nishanth Menon
| |