Messages in this thread | | | Subject | Re: [PATCH 20/20] regulator: vexpress: use devm_regulator_register() | From | Pawel Moll <> | Date | Wed, 25 Sep 2013 11:56:33 +0100 |
| |
On Wed, 2013-09-25 at 09:17 +0100, Jingoo Han wrote: > Use devm_regulator_register() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/regulator/vexpress.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/regulator/vexpress.c b/drivers/regulator/vexpress.c > index 4668c7f..f3ae28a 100644 > --- a/drivers/regulator/vexpress.c > +++ b/drivers/regulator/vexpress.c > @@ -96,7 +96,7 @@ static int vexpress_regulator_probe(struct platform_device *pdev) > config.driver_data = reg; > config.of_node = pdev->dev.of_node; > > - reg->regdev = regulator_register(®->desc, &config); > + reg->regdev = devm_regulator_register(&pdev->dev, ®->desc, &config); > if (IS_ERR(reg->regdev)) { > err = PTR_ERR(reg->regdev); > goto error_regulator_register; > @@ -119,7 +119,6 @@ static int vexpress_regulator_remove(struct platform_device *pdev) > struct vexpress_regulator *reg = platform_get_drvdata(pdev); > > vexpress_config_func_put(reg->func); > - regulator_unregister(reg->regdev); > > return 0; > }
I'm assuming it's following a patch adding devm_regulator_register()?
Based on this:
Acked-by: Pawel Moll <pawel.moll@arm.com>
Thanks!
Pawel
| |