Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 02/20] regulator: ab8500: use devm_regulator_register() | Date | Thu, 26 Sep 2013 10:25:38 +0900 |
| |
On Wednesday, September 25, 2013 7:21 PM, Sachin Kamat wrote: > On 25 September 2013 13:21, Jingoo Han <jg1.han@samsung.com> wrote: > > Use devm_regulator_register() to make cleanup paths simpler. > > > - for (i = 0; i < abx500_regulator.info_size; i++) { > > - struct ab8500_regulator_info *info = NULL; > > - info = &abx500_regulator.info[i]; > > - > > - dev_vdbg(rdev_get_dev(info->regulator), > > - "%s-remove\n", info->desc.name); > > - > > - regulator_unregister(info->regulator); > > - } > > + int err; > > > > /* remove regulator debug */ > > err = ab8500_regulator_debug_exit(pdev); > > Wouldn't re-ordering (unregistering after ab8500_regulator_debug_exit) > cause any problems here ? >
OK, I see. There is no ab8500_regulator_debug_exit() in the current kernel. However, in my opinion, ab8500_regulator_debug_exit() should be called, after regulator_unregister() is called.
I will remove this patch from next V2 patch series. Thank you.
Bengt Jonsson, If I am wrong, please let me know kindly. :-)
Best regards, Jingoo Han
| |