Messages in this thread | | | Date | Sat, 3 Aug 2013 12:10:09 -0700 | Subject | Re: [PATCH 3/3] exec: proc_exec_connector() should be called only once | From | Kees Cook <> |
| |
On Thu, Aug 1, 2013 at 12:05 PM, Oleg Nesterov <oleg@redhat.com> wrote: > A separate one-liner with the minor fix. > > PROC_EVENT_EXEC reports the "exec" event, but this message > is sent at least twice if search_binary_handler() is called > by ->load_binary() recursively, say, load_script(). > > Move it to exec_binprm(), this is "depth == 0" code too. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Yeah, looks right. I almost mentioned this while reading the other cleanup patch, but then you fixed it too. :)
Acked-by: Kees Cook <keescook@chromium.org>
Thanks,
-Kees
-- Kees Cook Chrome OS Security
| |