Messages in this thread | | | Date | Fri, 2 Aug 2013 16:09:16 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/3] exec: minor cleanups + minor fix |
| |
On 08/01, Oleg Nesterov wrote: > > Andrew, > > By discussion with Zach, please drop > > fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch > fs-binfmts-better-handling-of-binfmt-loops.patch > fs-binfmts-whitespace-fixes-with-scripts-cleanfile.patch > > Zach is working on v2. > > Meanwhile, can't we cleanup search_binary_handler() a bit? It > doesn't look nice imho. And we can certainly cleanup it more > (perhaps I'll try tomorrow). The error handling, request_module() > logic and even "for (try=0; try<2; try++)" looks horrible imho.
Seriously, I think this should be cleanuped too.
Zach, I am sorry if you already rebased your changes, I'll send a couple more patches today.
Oleg.
| |