Messages in this thread | | | Date | Sat, 3 Aug 2013 11:28:10 -0700 | Subject | Re: [PATCH 2/3] exec: kill "int depth" in search_binary_handler() | From | Kees Cook <> |
| |
On Thu, Aug 1, 2013 at 12:05 PM, Oleg Nesterov <oleg@redhat.com> wrote: > Nobody except search_binary_handler() should touch ->recursion_depth, > "int depth" buys nothing but complicates the code, kill it.
I'd like to see a comment added to binfmts.h's recursion_depth field that reminds people that recursion_depth is for search_binary_handler()'s use only, and a binfmt loader shouldn't touch it. Besides that, yeah, sensible clean up.
-Kees
-- Kees Cook Chrome OS Security
| |