| Date | Thu, 22 Aug 2013 15:51:56 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2 06/20] mm, hugetlb: return a reserved page to a reserved pool if failed |
| |
On Wed, Aug 21, 2013 at 03:24:13PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim <iamjoonsoo.kim@lge.com> writes: > > > If we fail with a reserved page, just calling put_page() is not sufficient, > > because put_page() invoke free_huge_page() at last step and it doesn't > > know whether a page comes from a reserved pool or not. So it doesn't do > > anything related to reserved count. This makes reserve count lower > > than how we need, because reserve count already decrease in > > dequeue_huge_page_vma(). This patch fix this situation. > > You may want to document you are using PagePrivate for tracking > reservation and why it is ok to that.
Okay! I will do it in next spin.
Thanks.
|