Messages in this thread | | | Date | Thu, 22 Aug 2013 18:17:47 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2 12/20] mm, hugetlb: remove vma_has_reserves() |
| |
On Thu, Aug 22, 2013 at 02:14:38PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim <iamjoonsoo.kim@lge.com> writes: > > > vma_has_reserves() can be substituted by using return value of > > vma_needs_reservation(). If chg returned by vma_needs_reservation() > > is 0, it means that vma has reserves. Otherwise, it means that vma don't > > have reserves and need a hugepage outside of reserve pool. This definition > > is perfectly same as vma_has_reserves(), so remove vma_has_reserves(). > > > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Thanks.
> > @@ -580,8 +547,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h, > > * have no page reserves. This check ensures that reservations are > > * not "stolen". The child may still get SIGKILLed > > */ > > - if (!vma_has_reserves(vma, chg) && > > - h->free_huge_pages - h->resv_huge_pages == 0) > > + if (chg && h->free_huge_pages - h->resv_huge_pages == 0) > > return NULL; > > > > /* If reserves cannot be used, ensure enough pages are in the pool */ > > @@ -600,7 +566,7 @@ retry_cpuset: > > if (page) { > > if (avoid_reserve) > > break; > > - if (!vma_has_reserves(vma, chg)) > > + if (chg) > > break; > > > > SetPagePrivate(page); > > Can you add a comment above both the place to explain why checking chg > is good enough ?
Yes, I can. But it will be changed to use_reserve in patch 13 and it represent it's meaning perfectly. So commeting may be useless.
Thanks.
> > -aneesh > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
| |