Messages in this thread Patch in this message | | | Date | Tue, 20 Aug 2013 11:43:32 +0800 | From | Chen Gang <> | Subject | [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() |
| |
When failure occures, __padata_add_cpu() and __padata_remove_cpu() will return -ENOMEM, which need be noticed in any cases (even in cleaning up cases).
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- kernel/padata.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c index 072f4ee..6a124cd 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -871,16 +871,20 @@ static int padata_cpu_callback(struct notifier_block *nfb, if (!pinst_has_cpu(pinst, cpu)) break; mutex_lock(&pinst->lock); - __padata_remove_cpu(pinst, cpu); + err = __padata_remove_cpu(pinst, cpu); mutex_unlock(&pinst->lock); + if (err) + return notifier_from_errno(err); case CPU_DOWN_FAILED: case CPU_DOWN_FAILED_FROZEN: if (!pinst_has_cpu(pinst, cpu)) break; mutex_lock(&pinst->lock); - __padata_add_cpu(pinst, cpu); + err = __padata_add_cpu(pinst, cpu); mutex_unlock(&pinst->lock); + if (err) + return notifier_from_errno(err); } return NOTIFY_OK; -- 1.7.7.6
| |