Messages in this thread | | | Date | Thu, 15 Aug 2013 14:34:22 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 2/3] sched: factor out code to should_we_balance() |
| |
On Tue, Aug 06, 2013 at 05:36:42PM +0900, Joonsoo Kim wrote: > - if (local_group) > - balance_cpu = group_balance_cpu(group); > -
> /* Bias balancing toward cpus of our domain */ > - if (local_group) { > - if (idle_cpu(i) && !first_idle_cpu && > - cpumask_test_cpu(i, sched_group_mask(group))) { > - first_idle_cpu = 1; > - balance_cpu = i; > - } > - > load = target_load(i, load_idx); > - } else {
> > - /* > - * First idle cpu or the first cpu(busiest) in this sched group > - * is eligible for doing load balancing at this and above > - * domains. In the newly idle case, we will allow all the cpu's > - * to do the newly idle load balance. > - */ > - if (local_group) { > - if (env->idle != CPU_NEWLY_IDLE) { > - if (balance_cpu != env->dst_cpu) { > - *balance = 0; > - return; > - } > - update_group_power(env->sd, env->dst_cpu); > - } else if (time_after_eq(jiffies, group->sgp->next_update)) > - update_group_power(env->sd, env->dst_cpu); > - }
> local_group = cpumask_test_cpu(env->dst_cpu, sched_group_cpus(sg));
> +static int should_we_balance(struct lb_env *env) > +{ > + struct sched_group *sg = env->sd->groups; > + struct cpumask *sg_cpus, *sg_mask; > + int cpu, balance_cpu = -1; > + > + /* > + * In the newly idle case, we will allow all the cpu's > + * to do the newly idle load balance. > + */ > + if (env->idle == CPU_NEWLY_IDLE) > + return 1; > + > + sg_cpus = sched_group_cpus(sg); > + sg_mask = sched_group_mask(sg); > + /* Try to find first idle cpu */ > + for_each_cpu_and(cpu, sg_cpus, env->cpus) { > + if (!cpumask_test_cpu(cpu, sg_mask) || idle_cpu(cpu))
Did you want to write !idle_cpu() ?
> + continue; > + > + balance_cpu = cpu; > + break; > + } > + > + if (balance_cpu == -1) > + balance_cpu = group_balance_cpu(sg); > + > + /* > + * First idle cpu or the first cpu(busiest) in this sched group > + * is eligible for doing load balancing at this and above domains. > + */ > + return balance_cpu != env->dst_cpu; > +}
| |